Improve hybrid AI evaluation of costs and delayed effects - #11493
Open
Madwand99 wants to merge 1 commit into
Open
Improve hybrid AI evaluation of costs and delayed effects#11493Madwand99 wants to merge 1 commit into
Madwand99 wants to merge 1 commit into
Conversation
Contributor
|
Getting a bit too hacky for my taste again 😩 |
Contributor
Author
The main "hack" here is that I evaluate delayed effects (such as the delayed draw from Lat-Nam's Legacy) as if it is happening immediately. There might be a better way to approximate this. Open to ideas! Or we could leave this approximation out and just be content with the safety checker just denying certain cards. |
Merged
Madwand99
force-pushed
the
ImproveOnePlaySafetyChecker
branch
from
August 7, 2026 14:55
de0b600 to
df4c24a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This improves the depth-zero safety check used by Hybrid AI when a play has explicit costs or mandatory delayed consequences.
Previously, the checker compared the final result directly against the original board state. This could reject reasonable plays because discarded, sacrificed, or temporarily removed cards appeared to be permanent losses. It also could not evaluate next-turn delayed draws because those triggers were not exposed until cleanup.
The checker now:
UnlessCostdelayed effects rather than inventing a choice for the AI.TriggerHandlernow retains pendingNextTurntriggers in a snapshot-accessible collection. Their normal game timing is unchanged: they still become active at cleanup exactly as before.Regression coverage includes:
Thanks to Codex for help with code and tests!